Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(robot-server): fix typing_extensions bug #5281

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

iansolano
Copy link
Contributor

@iansolano iansolano commented Mar 24, 2020

fix typing_extensions bug by removing Literal type and subsequently the library

closes #5275

overview

See here: #5275

Introduced a bug when importing Literal type from typing_extensions which is only used in development. Python 3.8 supports Literal types, so we can revert changes at a later date.

changelog

review requests

risk assessment

Verified

This commit was signed with the committer’s verified signature.
AgeManning Age Manning
…nse work

fix typing_extensions bug by removing Literal type and subsequently the library

closes #5275
@iansolano iansolano added ready for review fix PR fixes a bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). robot server Affects the `robot-server` project labels Mar 24, 2020
@iansolano iansolano requested a review from a team as a code owner March 24, 2020 22:55
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #5281 into edge will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #5281   +/-   ##
=======================================
  Coverage   61.80%   61.81%           
=======================================
  Files        1049     1050    +1     
  Lines       29926    29933    +7     
=======================================
+ Hits        18497    18504    +7     
  Misses      11429    11429           
Impacted Files Coverage Δ
...r/robot_server/service/models/json_api/__init__.py 100.00% <100.00%> (ø)
...er/robot_server/service/models/json_api/factory.py 100.00% <100.00%> (ø)
...er/robot_server/service/models/json_api/request.py 100.00% <100.00%> (ø)
...r/robot_server/service/models/json_api/response.py 100.00% <100.00%> (ø)
robot-server/robot_server/service/routers/item.py 79.31% <100.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa9346...f1245ff. Read the comment docs.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does boot now!

@iansolano iansolano merged commit dd3a915 into edge Mar 25, 2020
@iansolano iansolano deleted the robot-server_fix-typing-extensions branch March 25, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR fixes a bug robot server Affects the `robot-server` project robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: robot server fails to start on robot with httpapiv2 because it relies on typing_extensions
3 participants