Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): increase gen2 multi flow rate #5266

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

sfoster1
Copy link
Member

These bump the flow rates from 5mm/s plunger speed to 10 mm/s plunger
speed per hw suggestion.

Closes #5264

These bump the flow rates from 5mm/s plunger speed to 10 mm/s plunger
speed per hw suggestion.

Closes #5264
@sfoster1 sfoster1 added api Affects the `api` project refactor labels Mar 23, 2020
@sfoster1 sfoster1 requested review from ChrisYarka and a team March 23, 2020 18:22
Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #5266 into edge will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #5266      +/-   ##
==========================================
- Coverage   61.44%   61.44%   -0.01%     
==========================================
  Files        1043     1043              
  Lines       29623    29628       +5     
==========================================
+ Hits        18201    18204       +3     
- Misses      11422    11424       +2
Impacted Files Coverage Δ
protocol-designer/src/ui/steps/actions/actions.js 80% <0%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d28d38f...4db2699. Read the comment docs.

@sfoster1 sfoster1 merged commit 55a7e82 into edge Mar 23, 2020
@sfoster1 sfoster1 deleted the api_bump-gen2multi-flowrate branch March 23, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gen2 multi: default speeds to 10mm/s
3 participants