fix(protocol-designer): fix bug with selecting magnet > disengage step

[IanLondon]

overview

Closes #5247

The problem was that existing magnet steps were being treated the same as just-newly-created magnet steps. The desired behavior for just-newly-created steps

review requests

• Create a disengage step, save it, click off it to another step, select it again. It should still be a "disengage" in the form. Saving the re-opened form shouldn't make changes to the form (you can look at Redux state)

• You can create a magnet step, click off without saving, reselect, fill it out, and save it successfully

• Autofilling last entered engage height number if the previous step was disengage should still work w/o regression

• Ideas for tests? I thought about refactoring the if (newStepType === 'magnet') {...} else if (formData?.stepType === 'magnet') {...} into a function that could be tested on its own, but I'm not very motivated to put work into the pristine-never-saved form stuff since we're going to strip it out :/

risk assessment

PD only, shouldn't affect PRs in flight

[codecov]

Codecov Report

Merging #5257 into edge will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             edge    #5257      +/-   ##
==========================================
- Coverage   61.44%   61.43%   -0.01%     
==========================================
  Files        1043     1043              
  Lines       29623    29626       +3     
==========================================
+ Hits        18201    18202       +1     
- Misses      11422    11424       +2     

Impacted Files	Coverage Δ
protocol-designer/src/ui/steps/actions/actions.js	79.06% <50.00%> (-3.44%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d28d38f...e6967f0. Read the comment docs.

[jen-fong]

• Create a disengage step, save it, click off it to another step, select it again. It should still be a "disengage" in the form. Saving the re-opened form shouldn't make changes to the form (you can look at Redux state)
• Autofilling last entered engage height number if the previous step was disengage should still work w/o regression
• You can create a magnet step, click off without saving, reselect, fill it out, and save it successfully
  ^ When I create a disengage step without saving, clicking away to another step, then reselecting the disengage step, the disengage radio button is no longer defaulted

[IanLondon]

When I create a disengage step without saving, clicking away to another step, then reselecting the disengage step, the disengage radio button is no longer defaulted

@jen-fong yup that's the best we can get to right now I think, for pristine-never-saved forms we don't have them re-default, it should be similar to pipette field's behavior in mix/transfer steps

the thing I'm intending to test is that moduleId is populated for pristine-never-saved (if you fill it out and cannot save, it failed to populate moduleId)

[Kadee80]

🔍 ⬆️

• Disengage steps/step forms retain disengage selection
• You can create a magnet step, click off without saving, reselect, fill it out, and save it successfully
• Autofilling last entered engage height number if the previous step was disengage still works w/o regression