-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(robot-server): add /motors endpoints and tests #5242
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #5242 +/- ##
==========================================
+ Coverage 61.41% 61.44% +0.02%
==========================================
Files 1041 1043 +2
Lines 29609 29623 +14
==========================================
+ Hits 18185 18201 +16
+ Misses 11424 11422 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small request to avoid data duplication but looks good otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛥 LGTM
f8e6ea9
to
6361156
Compare
overview
Implement the
/motors
endpoints in robot-server's fastapi appchangelog
review requests
The ticket is to port the endpoint and unit tests.
I do not have a robot to test this on, so not 100% it will work on a robot.
risk assessment
Very low. These changes all live behind a feature flag which is not enabled.
closes #5192