Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(robot-server): add /motors endpoints and tests #5242

Merged
merged 3 commits into from
Mar 19, 2020

Conversation

amitlissack
Copy link
Contributor

overview

Implement the /motors endpoints in robot-server's fastapi app

changelog

  • separate the the motor models and routes from control into their own module
  • port tests from aiohttp into fastapi.
  • separate the tests into smaller tests.
  • implement the endpoints

review requests

The ticket is to port the endpoint and unit tests.
I do not have a robot to test this on, so not 100% it will work on a robot.

risk assessment

Very low. These changes all live behind a feature flag which is not enabled.

closes #5192

@amitlissack amitlissack added ready for review refactor robot server Affects the `robot-server` project labels Mar 17, 2020
@amitlissack amitlissack requested review from a team, iansolano and mcous and removed request for a team March 17, 2020 16:57
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #5242 into edge will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #5242      +/-   ##
==========================================
+ Coverage   61.41%   61.44%   +0.02%     
==========================================
  Files        1041     1043       +2     
  Lines       29609    29623      +14     
==========================================
+ Hits        18185    18201      +16     
+ Misses      11424    11422       -2     
Impacted Files Coverage Δ
...obot-server/robot_server/service/models/control.py 100.00% <ø> (ø)
...ver/robot_server/service/models/json_api/errors.py 100.00% <ø> (ø)
...bot-server/robot_server/service/routers/control.py 74.07% <ø> (+0.54%) ⬆️
robot-server/robot_server/service/main.py 100.00% <100.00%> (ø)
robot-server/robot_server/service/models/motors.py 100.00% <100.00%> (ø)
...obot-server/robot_server/service/routers/motors.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b313c95...6361156. Read the comment docs.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request to avoid data duplication but looks good otherwise

robot-server/robot_server/service/models/motors.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛥 LGTM

@amitlissack amitlissack force-pushed the robot_server_port_motors_fast_api branch from f8e6ea9 to 6361156 Compare March 19, 2020 18:11
@amitlissack amitlissack merged commit d28d38f into edge Mar 19, 2020
@amitlissack amitlissack deleted the robot_server_port_motors_fast_api branch April 14, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor robot server Affects the `robot-server` project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api: port motor endpoints from aiohttp to fastapi
4 participants