Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): fix typo in deck setup explanation modal #5104

Merged
merged 2 commits into from
Mar 2, 2020

Conversation

IanLondon
Copy link
Contributor

overview

Closes #5102

changelog

a protocol that tell the robot -> a protocol that tells the robot

review requests

  • Closes issue as described 🗒

@IanLondon IanLondon added ready for review fix PR fixes a bug protocol designer Affects the `protocol-designer` project labels Feb 27, 2020
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #5104 into edge will increase coverage by 0.22%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #5104      +/-   ##
==========================================
+ Coverage   68.79%   69.01%   +0.22%     
==========================================
  Files        1079     1084       +5     
  Lines       35966    36068     +102     
==========================================
+ Hits        24743    24894     +151     
+ Misses      11223    11174      -49
Impacted Files Coverage Δ
protocol-designer/src/components/ProtocolEditor.js 0% <ø> (ø) ⬆️
protocol-designer/src/file-types.js 0% <ø> (ø) ⬆️
app/src/networking/epic/index.js 100% <ø> (ø) ⬆️
...tocol-designer/src/components/FileSidebar/index.js 0% <ø> (ø) ⬆️
...rotocol-designer/src/step-forms/selectors/index.js 23.84% <ø> (-0.35%) ⬇️
...mponents/modals/AnnouncementModal/announcements.js 100% <100%> (ø)
api/tests/opentrons/protocol_api/test_util.py 100% <100%> (ø) ⬆️
.../tests/opentrons/hardware_control/test_adapters.py 100% <100%> (ø) ⬆️
app/src/networking/constants.js 100% <100%> (ø) ⬆️
api/tests/opentrons/conftest.py 93.01% <100%> (+0.05%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b86e4b7...43d536d. Read the comment docs.

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@IanLondon IanLondon merged commit 5a70562 into edge Mar 2, 2020
@IanLondon IanLondon deleted the pd_fix-typo-hint-modal-5102 branch March 2, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR fixes a bug protocol designer Affects the `protocol-designer` project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PD: Typo in hint modal
3 participants