build(js): upgrade babel and webpack toolchains #4959
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| // flow-typed signature: 8a7e73fee92a885e2d4c8f94329ddbe2 | ||
| // flow-typed version: c6154227d1/react-hot-loader_v4.6.x/flow_>=v0.104.x | ||
|
|
||
| // @flow | ||
| declare module "react-hot-loader" { | ||
| declare type Module = { id: string, ... }; | ||
|
|
||
| declare type ErrorReporterProps = {| | ||
| error: Error, | ||
| errorInfo: { componentStack: string, ... } | ||
| |} | ||
|
|
||
| declare export type ContainerProps = {| | ||
| children: React$Element<any>, | ||
| errorBoundary?: boolean, | ||
| errorReporter?: React$ComponentType<ErrorReporterProps>, | ||
| |} | ||
|
|
||
| declare export class AppContainer extends React$Component<ContainerProps> {} | ||
|
|
||
| declare export function hot(module: Module): <T: React$ComponentType<any>>( | ||
| Component: T, | ||
| props?: $Diff<ContainerProps, { children: React$Element<any>, ... }> | ||
| ) => T | ||
|
|
||
| declare export function cold<T: React$ComponentType<any>>(component: T): T | ||
|
|
||
| declare export function areComponentsEqual<T>( | ||
| typeA: React$ComponentType<T>, | ||
| typeB: React$ComponentType<T> | ||
| ): boolean | ||
|
|
||
| declare type Config = {| | ||
| logLevel: 'debug' | 'log' | 'warn' | 'error', | ||
| pureSFC: boolean, | ||
| pureRender: boolean, | ||
| allowSFC: boolean, | ||
| disableHotRenderer: boolean, | ||
| disableHotRendererWhenInjected: boolean, | ||
| ignoreSFC: boolean, | ||
| ignoreComponents: boolean, | ||
| errorReporter: React$ComponentType<ErrorReporterProps>, | ||
| ErrorOverlay: React$ComponentType<{ errors: Array<ErrorReporterProps>, ... }>, | ||
| onComponentRegister: (type: any, uniqueLocalName: string, fileName: string) => any, | ||
| onComponentCreate: (type: any, displayName: string) => any, | ||
| |} | ||
|
|
||
| declare export function setConfig(config: $Shape<Config>): void | ||
| } | ||
|
|
||
| declare module "react-hot-loader/root" { | ||
| import type { ContainerProps } from 'react-hot-loader'; | ||
|
|
||
| declare export function hot<T: React$ComponentType<any>>( | ||
| Component: T, | ||
| props?: $Diff<ContainerProps, { children: React$Element<any>, ... }> | ||
| ): T; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,11 @@ | ||
| // @flow | ||
| import * as React from 'react' | ||
| import { hot } from 'react-hot-loader/root' | ||
| import URLDeck from './URLDeck' | ||
| import './globals.css' | ||
|
|
||
| export function AppComponent() { | ||
| return <URLDeck /> | ||
| } | ||
|
|
||
| export const App = hot(AppComponent) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious — why is it that we were previously using semantic versioning for react and not we're not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judgement call and a safety thing:
react-domwith@hot-loader/react-dom@hot-loader/react-domneeds to matchreact-domLonger term, I think we should probably lock all of our production dependencies explicitely (I'm generally good keeping dev deps on semver). That being said, I'd rather not mess with all our app deps in this PR