feat(app): allow custom labware dir to be opened and reset to default #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
added
feature
Codecov Report
@@ Coverage Diff @@
## edge #4918 +/- ##
==========================================
- Coverage 67.59% 67.33% -0.27%
==========================================
Files 1056 1065 +9
Lines 35499 36266 +767
==========================================
+ Hits 23997 24419 +422
- Misses 11502 11847 +345
Continue to review full report at Codecov.
|
iansolano
approved these changes
Feb 5, 2020
| ]} | ||
| > | ||
| <p>{CLICK_RESET_SOURCE_TO_RESET_YOUR_CUSTOM_LABWARE_DIRECTORY}</p> | ||
| <p>{LABWARE_FILES_IN_YOUR_CURRENT_DIRECTORY_WILL_NOT_BE_MOVED}</p> |
app/src/components/AddLabwareCard/__tests__/ConfirmResetPathModal.test.js
Outdated
Show resolved
Hide resolved
app/src/components/AddLabwareCard/__tests__/ConfirmResetPathModal.test.js
Outdated
Show resolved
Hide resolved
| const addFailure = useSelector(getAddLabwareFailure) | ||
| const labwarePath = config.labware.directory | ||
| const handleOpenPath = () => dispatch(openCustomLabwareDirectory()) | ||
| const handleResetPath = () => dispatch(resetCustomLabwareDirectory()) | ||
| const handleChangePath = () => dispatch(changeCustomLabwareDirectory()) | ||
| const handleAddLabware = () => dispatch(addCustomLabware()) |
There was a problem hiding this comment.
obvi not for in this PR but I wonder if prefixing with dispatch makes more sense instead of handle
iansolano
approved these changes
Feb 7, 2020
| @@ -0,0 +1,65 @@ | |||
| // @flow | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This PR adds CTA's to the custom labware source directory UI to allow the user to:
Closes #4878, closes #4879
changelog
review requests
ACs copied from tickets
reset directory
open directory