Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): clear lw calibration state if top level home is called #4703

Merged
merged 2 commits into from
Jan 8, 2020
Merged

fix(app): clear lw calibration state if top level home is called #4703

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17fd115
fix(app): clear lw calibration state if top level home is called
b-cooper Jan 8, 2020
8d25fc5
use constant and add test
b-cooper Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/robot/reducer/calibration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export default function calibrationReducer(
return INITIAL_STATE

// reset calibration state on robot home
case 'robotControls:HOME':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constant is available as import { HOME } from '../../robot-controls'. Also, could you add tests for this behavior?

case 'robot:CLEAR_CALIBRATION_REQUEST':
return {
...state,
Expand Down