fix(app): display robot ip not robot ip subnet base #4411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr #4372 (ac74c12) added the netmask package (https://www.npmjs.com/package/netmask) to parse the robot's networking response of CIDR-format ip/subnetbits into a separate ip and subnet mask. Unfortunately, that PR was building a Netmask object and then using its base member to represent the IP address. However, a Netmask object only represents information _about the subnet_, not about a specific ip; the base attribute is the base address of the subnet, e.g. ip & subnetmask. Instead, split off the CIDR suffix and use the result as the IP address.
mcous
approved these changes
Nov 8, 2019
Codecov Report
@@ Coverage Diff @@
## edge #4411 +/- ##
=======================================
Coverage 55.95% 55.95%
=======================================
Files 899 899
Lines 25522 25522
=======================================
Hits 14282 14282
Misses 11240 11240
Continue to review full report at Codecov.
|
no worries, should have seen it in review anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr #4372 (ac74c12) added the netmask
package (https://www.npmjs.com/package/netmask) to parse the robot's networking
response of CIDR-format ip/subnetbits into a separate ip and subnet mask.
Unfortunately, that PR was building a Netmask object and then using its base
member to represent the IP address. However, a Netmask object only represents
information about the subnet, not about a specific ip; the base attribute is
the base address of the subnet, e.g.
ip & subnetmask.Instead, split off the CIDR suffix and use the result as the IP address.
Before:
Note the IP is displayed as 10.10.0.0, the subnet base
After:
Correct IP shown