chore(protocol-designer): expose gen2 multi pipettes behind ff #4398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add feature flag that enables the selection of GEN2 multi pipettes in the File tab. Closes #4396
b-cooper
added
chore
ready for review
protocol designer
IanLondon
suggested changes
Nov 7, 2019
| @@ -66,11 +68,15 @@ export default function ChangePipetteFields(props: Props) { | |||
| const renderPipetteSelect = (props: PipetteSelectProps) => { | |||
| const { tabIndex, mount } = props | |||
| const pipetteName = values[mount].pipetteName | |||
|
|
|||
| const nameBlacklist = useSelector(getEnableMultiGEN2Pipettes) | |||
There was a problem hiding this comment.
failing lint b/c this hook is called inside a fn, needs to move out into component body
Codecov Report
@@ Coverage Diff @@
## edge #4398 +/- ##
==========================================
- Coverage 55.99% 55.85% -0.15%
==========================================
Files 899 899
Lines 25503 25569 +66
==========================================
Hits 14281 14281
- Misses 11222 11288 +66
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature flag that enables the selection of GEN2 multi pipettes in the File tab.
Closes #4396