feat(app,api): allow rich version specification for python protocols #4358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows and requires apiv2 users to have 'apiLevel': '2.0' in their metadata dict. This is parsed and stored along with the protocol and passed along with RPC. This allows specification of API minor versions. Closes #4338
sfoster1
added
app
Codecov Report
@@ Coverage Diff @@
## edge #4358 +/- ##
==========================================
- Coverage 56.05% 55.65% -0.41%
==========================================
Files 896 897 +1
Lines 25125 25410 +285
==========================================
+ Hits 14085 14142 +57
- Misses 11040 11268 +228
Continue to review full report at Codecov.
|
Laura-Danielle
requested changes
Nov 5, 2019
| @@ -46,7 +50,7 @@ def _parse_python( | |||
| filename=ast_filename) | |||
| metadata = extract_metadata(parsed) | |||
| protocol = compile(parsed, filename=ast_filename, mode='exec') | |||
| version = infer_version(metadata, parsed) | |||
| version = get_version(metadata, parsed) | |||
There was a problem hiding this comment.
For this function, I think we should only evaluate the metadata blob for a version if we are in server api v2. For server api v1 we should default to infer the version using AST --> this will allow simulation to still be able to differentiate protocols while we finish up backcompat.
Laura-Danielle
approved these changes
Nov 5, 2019
IanLondon
approved these changes
Nov 6, 2019
| update.apiLevel = apiSession.api_level || 1 | ||
| if (Array.isArray(apiSession.api_level)) { | ||
| update.apiLevel = apiSession.api_level | ||
| } else if (apiSession.api_level) { |
There was a problem hiding this comment.
maybe it's obvious to ppl but might be good to have comment explaining that this case is to support back-compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows and requires apiv2 users to have
'apiLevel': '2.0'
in their metadata dict.
This is parsed and stored along with the protocol and passed along with RPC.
This allows specification of API minor versions.
Closes #4338