refactor(app): consolidate robot restart state, add restarting spinner #4283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Precursor to an upcoming PR for #4267
This PR consolidates state about whether a restart request has been issued for a given robot from the
http-api-client
(very old janky HTTP API state) anddiscovery
(good, but with restart status jammed in) state trees. It moves server restart to its own tree atrobotAdmin
.It also ditches the old (shoehorned in) restarting banner in-favor of a more buildroot-style full screen spinner, re-using the same spinner as robot homing.
changelog
review requests
Please test the user flows that this affects: