Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): consolidate robot restart state, add restarting spinner #4283

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Oct 24, 2019

overview

Precursor to an upcoming PR for #4267

This PR consolidates state about whether a restart request has been issued for a given robot from the http-api-client (very old janky HTTP API state) and discovery (good, but with restart status jammed in) state trees. It moves server restart to its own tree at robotAdmin.

It also ditches the old (shoehorned in) restarting banner in-favor of a more buildroot-style full screen spinner, re-using the same spinner as robot homing.

changelog

  • refactor(app): consolidate robot restart state, add restarting spinner

review requests

Please test the user flows that this affects:

  • Restart button in robot page
  • Factory reset wizard
  • Deck calibration wizard
  • Buildroot update wizard (should be completely unaffected)

@mcous mcous added app Affects the `app` project ready for review refactor labels Oct 24, 2019
@mcous mcous requested a review from a team October 24, 2019 04:17
@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #4283 into edge will increase coverage by 0.06%.
The diff coverage is 76.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #4283      +/-   ##
==========================================
+ Coverage   56.45%   56.51%   +0.06%     
==========================================
  Files         876      880       +4     
  Lines       24867    24860       -7     
==========================================
+ Hits        14038    14050      +12     
+ Misses      10829    10810      -19
Impacted Files Coverage Δ
app/src/http-api-client/index.js 100% <ø> (ø) ⬆️
app/src/reducer.js 0% <ø> (ø) ⬆️
.../src/components/CalibrateDeck/InstructionsModal.js 0% <ø> (ø) ⬆️
app/src/http-api-client/reducer.js 100% <ø> (ø) ⬆️
app/src/pages/Robots/RobotSettings.js 0% <0%> (ø) ⬆️
...pp/src/components/RobotSettings/ResetRobotModal.js 0% <0%> (ø) ⬆️
app/src/components/RobotSettings/ControlsCard.js 0% <0%> (ø) ⬆️
...c/components/RobotSettings/ReachableRobotBanner.js 0% <0%> (ø) ⬆️
app/src/robot/api-client/client.js 85.16% <0%> (ø) ⬆️
app/src/robot-admin/epic.js 100% <100%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f2eed...c6bdda7. Read the comment docs.

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Restart button in robot page
  • Factory reset wizard
  • Deck calibration wizard
  • Buildroot update wizard unaffected
  • [ ]

@mcous mcous merged commit d94c425 into edge Oct 24, 2019
@mcous mcous deleted the app_refactor-restart branch October 24, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants