Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(webpack): Fix webpack lockfile dependencies breaking app dev #4105

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Sep 25, 2019

overview

#4088's lockfile wasn't quite right and turns out make -C app dev would crap out as soon as any source change was made. This PR removes the necessary resolutions object in package.json in favor of getting the various transitive dependencies correct in the lockfile.

changelog

  • build(webpack): Fix webpack lockfile dependencies breaking app dev

review requests

  • Various make -C xyz dev tasks don't die on the first code change

Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was able to reproduce issue on edge and hot reloading works again in this PR 🎉

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #4105 into edge will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #4105   +/-   ##
=======================================
  Coverage   57.64%   57.64%           
=======================================
  Files         854      854           
  Lines       24063    24063           
=======================================
  Hits        13871    13871           
  Misses      10192    10192

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd2ad8f...57c6c36. Read the comment docs.

@mcous mcous merged commit 2321d83 into edge Sep 25, 2019
@mcous mcous deleted the build_fix-webpack-watch branch September 25, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants