Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app,labware-library): Upgrade to react-router 5 and fix imports #4084

Merged
merged 2 commits into from
Sep 19, 2019

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Sep 18, 2019

overview

This PR upgrades to react-router v5 (no breaking API changes, just a major version bump for reasons).

As part of the upgrade, this PR also fixes our incorrect dependencies in the app on react-router instead of the correct react-router-dom.

This required various flow type fixes, which this PR also incorporates.

changelog

  • fix(app,labware-library): Upgrade to react-router 5 and fix imports

review requests

  • Routing in the app still works
  • Routing in labware library still works

@mcous mcous added app Affects the `app` project ready for review fix PR fixes a bug labware labels Sep 18, 2019
@mcous mcous requested a review from a team September 18, 2019 20:14
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #4084 into edge will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #4084   +/-   ##
=======================================
  Coverage   57.23%   57.23%           
=======================================
  Files         851      851           
  Lines       23999    23999           
=======================================
  Hits        13737    13737           
  Misses      10262    10262
Impacted Files Coverage Δ
app/src/pages/Robots/RobotSettings.js 0% <ø> (ø) ⬆️
app/src/pages/Run.js 0% <ø> (ø) ⬆️
app/src/components/CalibrateDeck/index.js 0% <ø> (ø) ⬆️
app/src/components/ConnectPanel/RobotItem.js 0% <ø> (ø) ⬆️
app/src/pages/Robots/InstrumentSettings.js 0% <ø> (ø) ⬆️
app/src/components/nav-bar/NavButton.js 0% <ø> (ø) ⬆️
app/src/components/LostConnectionAlert/index.js 0% <ø> (ø) ⬆️
...pp/src/components/LostConnectionAlert/ModalCopy.js 0% <ø> (ø) ⬆️
app/src/pages/More/index.js 0% <ø> (ø) ⬆️
app/src/pages/Upload/index.js 0% <ø> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aa1556...18cfd22. Read the comment docs.

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔗

  • LL routes still work
  • App routes still work

@mcous mcous merged commit 5595f8d into edge Sep 19, 2019
@mcous mcous deleted the chore_react-router branch September 19, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project fix PR fixes a bug labware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants