-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app-shell): Update Electron and add macOS app notarization #4011
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #4011 +/- ##
==========================================
+ Coverage 57.68% 58.01% +0.32%
==========================================
Files 828 829 +1
Lines 23500 23713 +213
==========================================
+ Hits 13557 13757 +200
- Misses 9943 9956 +13
Continue to review full report at Codecov.
|
Making a note about this here so it doesn't get forgotten: OT App page on website currently lists supported OS as @mcous please confirm i'm correct here with the new version support |
@Kadee80 that is correct. Filed Opentrons/opentrons-dot-com#230 to track |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
overview
This PR updates a lot of our underlying Electron / app packaging tooling to ensure we are ready for new security requirements in the upcoming version of macOS (10.15 Catalina).
This Electron update will bring reliability and security improvements to all our users, but out of necessity, is going to introduce a little bit of user pain for our Linux and Windows users out of the gate in exchange for a better long term experience.
Closes #3997, closes #2567
the good
/Applications
folderflatMap
!)the bad
We need to recommend to Windows users that they uninstall 3.11.x before installing this update to avoid weird problems caused by installation location bugs fixed in electron-builderwash
changelog
review requests
This PR is going to require stress testing on all of our OS's. Given that we don't have a choice on this update (because of macOS security), I think as long as we do various smoke tests with this PR, we should rely on our release QA to really make sure this is solid. Scariest areas that the Electron side of things deals with that we'll need to keep an eye on: