fix(update-server): Fix hash in SSH key upload confirmation response #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `f` was forgotten from an f-string, causing the "Added key {hashval}" response to an SSH key upload to include the literal string "{hashval}".
Codecov Report
@@ Coverage Diff @@
## edge #3947 +/- ##
=======================================
Coverage 57.53% 57.53%
=======================================
Files 829 829
Lines 23455 23455
=======================================
Hits 13496 13496
Misses 9959 9959
Continue to review full report at Codecov.
|
|
Awesome catch @SyntaxColoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
When you send a POST request to upload a new SSH key, the robot responds with a message
Added key {hashval}.Presumably the actual hash was intended to be substituted there, but the message was accidentally written as a regular string instead of an f-string.changelog