-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(shared-data): update P10 tip totalLiquidVolume #3929
Conversation
89ffef7
to
c06d781
Compare
Codecov Report
@@ Coverage Diff @@
## edge #3929 +/- ##
=========================================
+ Coverage 57.3% 59.71% +2.41%
=========================================
Files 822 829 +7
Lines 23411 25477 +2066
=========================================
+ Hits 13415 15214 +1799
- Misses 9996 10263 +267
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just capturing an offline conversation:
- The tiprack currently known as the "P10" (10µl) tiprack will be used for both the existing P10 and new P20 pipettes.
- This PR updates the labware definition for the tiprack to a 20µl max volume, reflecting the tip's actual max volume, but leaves the name the same (so as not to break old protocols)
- So, for now, users will have to (counterintuitively) use the 10µl tip with the 20µl pipette.
- We can improve this in the future by changing the name or creating a second labware definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any change to non-metadata stuff in a published labware definition requires version
to be incremented
Otherwise existing protocols, both Python and PD protocols that use the def, could unexpectedly change their behavior on the next release of PD/API.
also this needs to be a new file called The original |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, exposes some deeper issues with labware versioning though.
Posting here for history sake: We agreed to add a labware definition named |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"brand": "Opentrons", | ||
"brandId": [], | ||
"links": [ | ||
"https://shop.opentrons.com/collections/opentrons-tips/products/opentrons-10ul-tips" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we edit the shop so there's a https://shop.opentrons.com/collections/opentrons-tips/products/opentrons-20ul-tips (not 10) and change this link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add this to the new ticket #3964 when we are ready to publish this definition on the labware library
overview
The P10 tips can physically hold up to 20 uL rather than 10 uL as described in the
opentrons_96_tiprack_10uL
definition. When attached to a P20, the 10 uLtotalLiquidVolume
of the tip is restricting the pipette from aspirating to its full capacity.changelog
totalLiquidVolume
from 10 to 20review requests
There's a function that's already taking both the pipette's and tip max volume into account when handling volume logic (see #3674 , #3604). This means that when a P10 tip is used with a P10 pipette, the max volume that the pipette can aspirate is 10 uL; but when used with a P20, the max volume is 20 uL.
The name of the tiprack remains the same for backward compatibility purposes. 🤷♀ Any objections?