-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(app): add thermocycler prompts to calibration flow #3912
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #3912 +/- ##
==========================================
- Coverage 57.53% 57.47% -0.07%
==========================================
Files 819 822 +3
Lines 23259 23315 +56
==========================================
+ Hits 13382 13400 +18
- Misses 9877 9915 +38
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Will approve once tested on a robot
} | ||
} | ||
|
||
function mergeProps(stateProps: SP, dispatchProps: DP, ownProps: OP): Props { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man this diff feels good
const handleClick = () => { | ||
// $FlowFixMe: robotActions.returnTip is not typed | ||
returnTip() | ||
dispatch(push(`/run`)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[No change necessary] In this case, I think we'd more often than not use a <Link>
with an onClick
and to
rather than dispatching a push
event via connected-react-router
I'm not super satisfied with the routing situation as it exists in the app, so if you feel that way too as you're working on it, feel free to propose any changes. I'm hoping things will get better if and when react-router ever ships their hooks API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚗️
Add helpful UI through the calibration process of a protocol that involves a thermocycler.
Specifically to ensure the latch is secure and the pcr seal is placed before the run starts.
Closes #3068, Closes #3583
Review Requests