fix(app): make shell remote check lazier to avoid spurious assertions

[mcous]

overview

In investigating @IanLondon's reports of a circular-dependency based assertion, I found that the root of the problem was an assertion firing for a missing remote during import (i.e. before the code was actually running).

I'm not 100% sure of the Electron and/or webpack mechanics that are allowing that assertion to be hit, but moving the assertion to property access time fixes the issue.

@IanLondon: app/src/protocol/selectors.js creates a logger (via app/src/protocol/protocol-data.js), which relies on the remote module to send logs over to the desktop shell to save to a file. Rebasing #3891 over this branch fixed the issues for me.

changelog

• fix(app): make shell remote check lazier to avoid spurious assertions

review requests

• No AssertionErrors in the console in normal operation
• No AssertionErrors in the console when feat(app): display custom labware on deckmap #3891 is layered over this branch

[codecov]

Codecov Report

Merging #3895 into edge will increase coverage by 22.88%.
The diff coverage is 25%.

@@             Coverage Diff             @@
##             edge    #3895       +/-   ##
===========================================
+ Coverage   34.65%   57.53%   +22.88%     
===========================================
  Files         731      819       +88     
  Lines       11630    23259    +11629     
===========================================
+ Hits         4030    13382     +9352     
- Misses       7600     9877     +2277

Impacted Files	Coverage Δ
app/src/shell/remote.js	0% <0%> (ø)	⬆️
app/src/shell/index.js	70.58% <100%> (-4.42%)	⬇️
opentrons/data_storage/database_queries.py	100% <0%> (ø)
opentrons/legacy_api/containers/placeable.py	93.94% <0%> (ø)
opentrons/drivers/utils.py	72.72% <0%> (ø)
opentrons/protocol_api/execute.py	68.29% <0%> (ø)
opentrons/hardware_control/modules/mod_abc.py	75% <0%> (ø)
opentrons/hardware_control/controller.py	59.54% <0%> (ø)
opentrons/legacy_api/instruments/pipette.py	94.96% <0%> (ø)
opentrons/api/models.py	85.18% <0%> (ø)
... and 80 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd604e2...8a0ed3f. Read the comment docs.

[IanLondon]

😎 💥