Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add a log aggregation optout #3868

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Conversation

sfoster1
Copy link
Member

We already have the /settings/log_level/upstream, but it's a lot easier to add a
simple advanced setting that disables the aggregation, which the app can trigger
a modal on.

Also refactors syslog control out of the endpoint implementation.

Closes #3866

We already have the /settings/log_level/upstream, but it's a lot easier to add a
simple advanced setting that disables the aggregation, which the app can trigger
a modal on.

Also refactors syslog control out of the endpoint implementation.

Closes #3866
@sfoster1 sfoster1 added feature Ticket is a feature request / PR introduces a feature api Affects the `api` project labels Aug 15, 2019
@sfoster1 sfoster1 requested a review from a team August 15, 2019 17:32
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #3868 into edge will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             edge   #3868      +/-   ##
=========================================
- Coverage   34.43%   34.3%   -0.14%     
=========================================
  Files         743     743              
  Lines       11811   11965     +154     
=========================================
+ Hits         4067    4104      +37     
- Misses       7744    7861     +117
Impacted Files Coverage Δ
app/src/components/nav-bar/NavButton.js 0% <0%> (ø) ⬆️
app/src/components/ConnectPanel/RobotItem.js 0% <0%> (ø) ⬆️
...c/components/RobotSettings/AdvancedSettingsCard.js 0% <0%> (ø) ⬆️
app/src/pages/Robots/RobotSettings.js 0% <0%> (ø) ⬆️
app-shell/src/buildroot/index.js 0% <0%> (ø) ⬆️
app-shell/src/main.js 0% <0%> (ø) ⬆️
...pp/src/components/RobotSettings/InformationCard.js 0% <0%> (ø) ⬆️
app/src/shell/index.js 78.12% <0%> (+3.12%) ⬆️
app/src/http-api-client/server.js 79.2% <0%> (+3.25%) ⬆️
app/src/config/index.js 29.72% <0%> (+4.72%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13d8128...2e8297b. Read the comment docs.

Copy link
Contributor

@btmorr btmorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍘 Tested selector persistence and status endpoint with @mcous on #3869 . Didn't double-check that the logs are not sent up.

@sfoster1 sfoster1 merged commit ccb0b94 into edge Aug 16, 2019
@sfoster1 sfoster1 deleted the api_add-log-aggregation-optout branch August 16, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buildroot: Add robot setting to disable log upload
2 participants