feat(app): prompt to open TC lid before labware calibration #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a mechanism to open the lid of the Thermocycler Module during pre-run calibration, so that the contained labware can be calibrated. Closes #3066
b-cooper
added
feature
Codecov Report
@@ Coverage Diff @@
## edge #3853 +/- ##
==========================================
- Coverage 34.51% 34.44% -0.08%
==========================================
Files 742 743 +1
Lines 11770 11801 +31
==========================================
+ Hits 4063 4065 +2
- Misses 7707 7736 +29
Continue to review full report at Codecov.
|
mcous
approved these changes
Aug 9, 2019
| ) | ||
| } | ||
|
|
||
| function mapDispatchToProps(dispatch: Dispatch, ownProps: OP): DP { |
There was a problem hiding this comment.
Not a change request, but since this is a new component that only uses mapDispatchToProps, useDispatch could make this component more compact and (in theory) more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Provide a mechanism to open the lid of the Thermocycler Module during pre-run calibration, so that the contained labware can be calibrated.
Closes #3066
Review Requests
NOTE
The firmware/hardware combination will not report 'closed' because of latch complications, until new units are in, the behavior of the "Open Lid" button will be either behave as if it's in progress. In order to allow testing, we keep the button enabled for now, despite the loading state. There is a TODO