feat(app): add GEN2 images to change pipette #3734
Conversation
For a number of FE use cases, it is helpful to be able to distinguish "categories" of pipette names. This adds a 'displayCategory' key and value to the pipetteNameSpecs and schema.
Add images for GEN2 single and multi pipettes when changing or viewing attached pipettes. Closes #3630
For a number of FE use cases, it is helpful to be able to distinguish "categories" of pipette names. This adds a 'displayCategory' key and value to the pipetteNameSpecs and schema.
b-cooper
added
app
Codecov Report
@@ Coverage Diff @@
## edge #3734 +/- ##
==========================================
+ Coverage 57.14% 57.15% +<.01%
==========================================
Files 815 815
Lines 22489 22490 +1
==========================================
+ Hits 12852 12854 +2
+ Misses 9637 9636 -1
Continue to review full report at Codecov.
|
b-cooper
added
protocol designer
|
|
||
| // TODO(mc, 2018-04-06): there must be a better way... |
|
|
||
| .flipped_image { | ||
| transform: scaleX(-1); | ||
| filter: FlipH; |
There was a problem hiding this comment.
Looking at caniuse I think transform: scaleX(-1) should be enough to get us coverage all the way back to IE9 (with our autoprefixing that's already in place). We should get together and propose an actual browser support spec for our projects
|
|
||
| type Props = { | ||
| channels?: number, | ||
| pipetteSpecs?: ?PipetteNameSpecs | ?PipetteModelSpecs, |
There was a problem hiding this comment.
I think in this case we'll be good, but we should consider making PipetteNameSpecs and PipetteModelSpecs exact objects to make sure unions behave a little better
| imgSrc = channels === 1 ? singleGEN2Src : multiGEN2Src | ||
| break | ||
| } | ||
| default: |
There was a problem hiding this comment.
What's the purpose of the default above case 'OG' here? Some sort of flow exhaustiveness check?
There was a problem hiding this comment.
Yup, I was reasoning that it should fall back to OG images, but I can see an argument for displaying nothing if the displayCategory is missing
Overview
Add images for GEN2 single and multi pipettes when changing or viewing attached pipettes.
Closes #3630
Changelog
InstrumentDiagramin CL to allow for image differentiation on 3 factors (mount, displayCategory, channels)InstructionStepin RA to allow for image differentiation on 5 factors (mount, displayCategory, channels, direction, diagram)require()passing a template string as a param, add flow config to ignore this case