refactor(app): Reconfigure app-shell remote access #3683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This PR fixes a bunch of memory leaks in unit tests surrounding the mocks for app-shell remote module access in app.
global
to mimicwindow
in the app UI at runtimeglobal
were generated byjest.genMockFromModule
Rather than do that, this PR centralizes access to the
window
attached remote methods and then mocks that single access file. This helps the tests and is also just a better idea.P.S. If you're interested in the background of why we attach stuff to
window
for remote module access, see #2374changelog
review requests
In my testing, this PR fixes the heap issues in #3672, so hopefully we can get this one in and then followup with that