Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): Remove all tests that use the unittest library module #3593

Merged
merged 2 commits into from
Jun 17, 2019

Conversation

sfoster1
Copy link
Member

This has been a todo for a while; we use pytest and pytest has only limited
integration with unittest. Removing these allows for future use of pytest
features that do not work with unittest, like more complex fixturing.

The files that have unittest in the name unfortunately still do because often there's duplicates!

This has been a todo for a while; we use pytest and pytest has only limited
integration with unittest. Removing these allows for future use of pytest
features that do not work with unittest, like more complex fixturing.
@sfoster1 sfoster1 added api Affects the `api` project chore medium labels Jun 17, 2019
@sfoster1 sfoster1 added this to the API Backwards Compatibility milestone Jun 17, 2019
@sfoster1 sfoster1 requested a review from a team June 17, 2019 20:12
Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦅

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #3593 into edge will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #3593   +/-   ##
=======================================
  Coverage   28.92%   28.92%           
=======================================
  Files         730      730           
  Lines       13083    13083           
=======================================
  Hits         3784     3784           
  Misses       9299     9299

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953abad...102baae. Read the comment docs.

@sfoster1 sfoster1 merged commit 07ec69e into edge Jun 17, 2019
@sfoster1 sfoster1 deleted the api_remove-unittest branch June 17, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project chore medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants