Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(labware-library): Update TableTitle expandable styles #3578

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

Kadee80
Copy link
Contributor

@Kadee80 Kadee80 commented Jun 12, 2019

overview

This PR implements a UI change request:
forkatie_library

changelog

  • refactor(labware-library): Update TableTitle expandable styles

review requests

http://sandbox.labware.opentrons.com/lablib_table-title-stylefix

  • TableTitle bottom border no longer expands below the measurement guide when expanded

@Kadee80 Kadee80 added app Affects the `app` project ready for review fix PR fixes a bug small labels Jun 12, 2019
@Kadee80 Kadee80 self-assigned this Jun 12, 2019
@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #3578 into edge will increase coverage by 1.24%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #3578      +/-   ##
==========================================
+ Coverage   27.61%   28.85%   +1.24%     
==========================================
  Files         705      728      +23     
  Lines       11557    13060    +1503     
==========================================
+ Hits         3191     3769     +578     
- Misses       8366     9291     +925
Impacted Files Coverage Δ
...are-library/src/components/ui/LabeledValueTable.js 0% <ø> (ø) ⬆️
labware-library/src/components/ui/TableTitle.js 0% <0%> (ø)
update-server/otupdate/balena/bootstrap.py 20% <0%> (ø)
update-server/otupdate/migration/file_actions.py 81.64% <0%> (ø)
update-server/otupdate/migration/__init__.py 100% <0%> (ø)
update-server/otupdate/buildroot/config.py 31.25% <0%> (ø)
update-server/otupdate/balena/endpoints.py 23.33% <0%> (ø)
update-server/otupdate/buildroot/constants.py 100% <0%> (ø)
update-server/otupdate/buildroot/update.py 32.14% <0%> (ø)
update-server/otupdate/balena/__main__.py 0% <0%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update befded9...7f41ba4. Read the comment docs.

Copy link

@pantslakz pantslakz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚛️

@Kadee80 Kadee80 merged commit c5b8fc6 into edge Jun 12, 2019
@Kadee80 Kadee80 deleted the lablib_table-title-stylefix branch June 12, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project fix PR fixes a bug small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants