Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-data): add version, schemaVersion, and namespace keys to v2 labware #3469

Merged
merged 3 commits into from
May 21, 2019

Conversation

IanLondon
Copy link
Contributor

@IanLondon IanLondon commented May 21, 2019

overview

This is a small step towards schema changes discussed in #3454

Also since we have version, deleted deprecated key (thanks @sfoster1 for the suggestion)

changelog

  • add version, schemaVersion, and namespace keys to v2 labware schema + all definitions2/ + all v2 labware fixtures. Delete deprecated key.
  • update create labware functions to take namespace and version. Namespace defaults to "custom_beta" and version defaults to 1 if not specified in those 2 fns.

review requests

  • sanity check

…v2 labware

this is a low-interference step towards schema changes discussed in #3454
Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👁

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥽

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #3469 into edge will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##            edge    #3469      +/-   ##
=========================================
+ Coverage   52.4%   52.42%   +0.01%     
=========================================
  Files        796      796              
  Lines      23194    23199       +5     
=========================================
+ Hits       12155    12161       +6     
+ Misses     11039    11038       -1
Impacted Files Coverage Δ
shared-data/js/labwareTools/index.js 96.55% <85.71%> (+2.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3513794...4d441f8. Read the comment docs.

Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚦

Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bon

@IanLondon IanLondon merged commit da03025 into edge May 21, 2019
@IanLondon IanLondon deleted the shared-data_add-namespace-version-keys-to-defs branch May 21, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants