-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shared-data): add version, schemaVersion, and namespace keys to v2 labware #3469
feat(shared-data): add version, schemaVersion, and namespace keys to v2 labware #3469
Conversation
…v2 labware this is a low-interference step towards schema changes discussed in #3454
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥽
Codecov Report
@@ Coverage Diff @@
## edge #3469 +/- ##
=========================================
+ Coverage 52.4% 52.42% +0.01%
=========================================
Files 796 796
Lines 23194 23199 +5
=========================================
+ Hits 12155 12161 +6
+ Misses 11039 11038 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bon
overview
This is a small step towards schema changes discussed in #3454
Also since we have
version
, deleteddeprecated
key (thanks @sfoster1 for the suggestion)changelog
version
,schemaVersion
, andnamespace
keys to v2 labware schema + alldefinitions2/
+ all v2 labware fixtures. Deletedeprecated
key."custom_beta"
and version defaults to 1 if not specified in those 2 fns.review requests