Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): assorted form tweaks #3260

Merged
merged 7 commits into from
Mar 26, 2019

Conversation

IanLondon
Copy link
Contributor

overview

Closes #3214: change "Change Tip" tooltip copy (see issue for copy)

Closes #3040: add missing tooltips:

  • Well order icon => "Well order"
  • Touch tip => "Touch tip to each side of well (after aspirating / after dispensing)"

Closes #3041:
Move advanced settings in Transfer form so they go:
ASPIRATE:

  • pre wet tip
  • mix
  • air gap
  • touch tip

DISPENSE

  • mix
  • touch tip
  • blowout

changelog

review requests

@IanLondon IanLondon added the protocol designer Affects the `protocol-designer` project label Mar 26, 2019
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #3260 into edge will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #3260      +/-   ##
==========================================
+ Coverage   53.65%   53.65%   +<.01%     
==========================================
  Files         702      710       +8     
  Lines       20602    20766     +164     
==========================================
+ Hits        11053    11143      +90     
- Misses       9549     9623      +74
Impacted Files Coverage Δ
...ocol-designer/src/components/StepEditForm/utils.js 0% <ø> (ø) ⬆️
...-designer/src/components/StepEditForm/forms/Mix.js 0% <ø> (ø) ⬆️
...omponents/StepEditForm/fields/TipPosition/index.js 0% <ø> (ø) ⬆️
.../components/StepEditForm/fields/WellOrder/index.js 0% <0%> (ø) ⬆️
.../StepEditForm/forms/MoveLiquid/SourceDestFields.js 0% <0%> (ø) ⬆️
...ponents/StepEditForm/fields/ChangeTip/ChangeTip.js 0% <0%> (ø) ⬆️
app/src/config/index.js 34.61% <0%> (-20.95%) ⬇️
discovery-client/src/index.js 89.06% <0%> (-2.34%) ⬇️
app-shell/src/config.js 24% <0%> (-1%) ⬇️
...pp/src/components/AppSettings/AddManualIp/index.js 0% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef5123...e41538b. Read the comment docs.

@IanLondon IanLondon force-pushed the pd_form-tweaks-3214-3040-3041 branch from 1dfb2ec to 9a2cc6c Compare March 26, 2019 14:44
Copy link
Contributor

@howisthisnamenottakenyet howisthisnamenottakenyet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except two things:

  1. I'm getting the text field cursor flashing in the change tip dropdown field. The one that looks like "|".
  2. One of the tooltips in the change tip dropdown flashes in/out of existence.

Super hard to describe verbally so here's a gif:
tooltip flashing

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📨

@IanLondon IanLondon merged commit a14fca9 into edge Mar 26, 2019
@IanLondon IanLondon deleted the pd_form-tweaks-3214-3040-3041 branch March 26, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol designer Affects the `protocol-designer` project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants