refactor(app): Add ability to add/remove manual IP addresses

[Kadee80]

overview

This PR closes #2742 and adds the ability to add or remove manual IP addresses / hostnames via the advanced settings modal in app settings.

This PR does NOT:

• check for added IPs in discovery within this modal to add the spinner/checkmark icons to IpList

changelog

• feat(app): Add ability to add/remove manual IP addresses
• refactor(components): Update ButtonProps to receive optional buttonRef

review requests

• comment out line 55 in app-shell/Makefile
• make -C app dev OT_APP_DEV_INTERNAL__MANUAL_IP=1
• make -C api dev
• dev USB does not render in initial app robot list

---

• Go to app settings page
• Click [manage] button in advanced settings (Manually Add Robot Network Addresses)
• Modal opens with instructions and empty input
• [+] button is disabled until text is entered

---

• enter localhost as text and click [+] to submit
• localhost renders below in IpList as an IpListItem with [-] button
• discovery.candidates array in config.json now contains 'localhost'

---

• enter any random string in the AddManualIpForm above and submit [+]
• that random string renders below in IpList as an IpListItem with [-] button
• discovery.candidates array in config.json now contains that random string

---

• Click [-] button to remove the random string from the list
• Clicking [-] removes the appropriate IpItem from the IpList
• discovery.candidates array in config.json no longer contains that random string

---

• Navigate to Robot tab in app and click [refresh list]
• Dev USB shows up in robots list
• localhost appears in discovery.json

[codecov]

Codecov Report

Merging #3256 into edge will increase coverage by 1.25%.
The diff coverage is 7.79%.

@@            Coverage Diff            @@
##             edge   #3256      +/-   ##
=========================================
+ Coverage   53.74%     55%   +1.25%     
=========================================
  Files         700     704       +4     
  Lines       20563   21985    +1422     
=========================================
+ Hits        11052   12093    +1041     
- Misses       9511    9892     +381

Impacted Files	Coverage Δ
discovery-client/src/index.js	85.85% <0%> (-5.54%)	⬇️
...p/src/components/AppSettings/AddManualIp/IpList.js	0% <0%> (ø)
app/src/config/index.js	33.33% <0%> (-22.23%)	⬇️
...p/src/components/AppSettings/AddManualIp/IpItem.js	0% <0%> (ø)
.../src/components/AppSettings/AddManualIp/IpField.js	0% <0%> (ø)
app-shell/src/config.js	24% <0%> (-1%)	⬇️
...components/AppSettings/AddManualIp/ManualIpForm.js	0% <0%> (ø)
...pp/src/components/AppSettings/AddManualIp/index.js	0% <0%> (ø)	⬆️
components/src/buttons/Button.js	100% <100%> (ø)	⬆️
app-shell/src/discovery.js	84.61% <50%> (-2.89%)	⬇️
... and 41 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d09d0a...0b3cc88. Read the comment docs.

[btmorr]

🌔 Looks great. Tested locally.

[Kadee80]

After chatting with the FE team, refs in buttons raises more issues than it solves. Going to strip out refs in buttons in favor of a pure CSS solution to the .blur() issue it solved. PR is now a WIP

[mcous]

One comment but otherwise good to merge 💵

[mcous]

Unused set can be removed