(Chore) App 3.0 - Collect both app and API coverage #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
requested review from
astaff,
SimplyAhmazing,
Kadee80,
IanLondon and
jarmg
Kadee80
approved these changes
Aug 28, 2017
astaff
approved these changes
Aug 28, 2017
.travis.yml
Outdated
| @@ -42,23 +42,26 @@ before_install: | |||
|
|
|||
| install: | |||
| - source scripts/install-${TRAVIS_OS_NAME} # OS-specific installs | |||
| # TODO(mc, 2017-08-28): these should be in requirements.txt, but also are | |||
There was a problem hiding this comment.
pyyaml and coveralls are for coveralls, so it's safe to remove these, since we are no longer using it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, another CI-focused chore PR here. This one lets us start collecting coverage information from both the API and the app (also, badges!).
I've switch our coverage provider from Coveralls to Codecov. I've used both in the past, with all my newer projects using Codecov. They're not that different, it's just the Codecov makes multi-language projects super easy, and Coveralls makes it less easy than that. Check out the report for this PR: https://codecov.io/gh/OpenTrons/opentrons/branch/v3-chore-coverage
I've also started a top-level Makefile to start coordinating stuff that until now has only lived in travis.yml. Basically, it has some tasks to call sub-tasks in the Makefiles of
appandapi. Right now it's got:make install- Install all pip and npm dependenciesmake test- Run all project testsmake coverage- Upload all coverage reports to codecovReviewers: please give this a sanity check and let me know if you disagree with any decisions I've made here and/or know of better ways to do things