feat(app): Add robot pipettes, versions, FFs to mixpanel and intercom #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
added
feature
Codecov Report
@@ Coverage Diff @@
## edge #3059 +/- ##
==========================================
- Coverage 53.58% 53.52% -0.06%
==========================================
Files 678 678
Lines 19695 19718 +23
==========================================
+ Hits 10553 10554 +1
- Misses 9142 9164 +22
Continue to review full report at Codecov.
|
Kadee80
approved these changes
Feb 15, 2019
There was a problem hiding this comment.
🌮 Tested on wandering-katie with mac build.
Can confirm in debug: Intercom update contained
- API version
- Smoothie version
- Left pipette model (already present in Intercom profile)
- Right pipette model (already present in Intercom profile)
- Robot feature flag settings
Codecov Report
@@ Coverage Diff @@
## edge #3059 +/- ##
==========================================
- Coverage 53.58% 53.52% -0.06%
==========================================
Files 678 678
Lines 19695 19718 +23
==========================================
+ Hits 10553 10554 +1
- Misses 9142 9164 +22
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This PR adds data about the connected robot to certain analytics events as well as the user's Intercom support profile:
It submits this data to Intercom any time that data may change, and to MixPanel on:
Closes #3009, closes #3010
changelog
review requests
Without any environment variables set, you will see debug logs for the Mixpanel event (
debug: Trackable event) and for the Intercom event (debug: Intercom update).If you test with the production app, you should see these events go all the way to Mixpanel and Intercom. Make sure you're opted into analytics, and you can get your Mixpanel and Intercom user IDs from the app's config file (see app-shell README for config file location) under the
analyticsandsupportkeys, respectively.