-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(babel): Upgrade babel to v7 #2858
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #2858 +/- ##
=========================================
+ Coverage 51.21% 53.51% +2.3%
=========================================
Files 657 660 +3
Lines 18515 19555 +1040
=========================================
+ Hits 9482 10465 +983
- Misses 9033 9090 +57
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎏
- app
- app-shell
- components
- discovery-client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- labware-designer
- protocol-designer
- protocol-library-kludge
- shared-data
Make sure to fix typo in webpack-config/lib/env.js before merge but this looks great! I like the analyzer.
webpack-config/lib/env.js
Outdated
ENABLE_ANALYZER: | ||
process.env.ANALYZER && | ||
process.env.ANALYZER !== 'false' && | ||
process.env.ANALZER !== '0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ANALZER
= typo
also not sure why it's !== 'false
instead of (ANALYZER === 'true' || ANALYZER === '1')
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch! Will fix up
The !==
stuff is based on my own personal expectations. Not at all married to it, but it's an attempt to allow $ANALYZER
to be any truthy value to enable the analyzer (e.g. ANALYZER=yes
, ANALYZER=foo
, ANALYZER=99
)
742c6f5
to
00b6a96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👶
overview
Chore PR to upgrade babel to v7 (as discussed in #2815 and #2568). Key benefits:
babel.config.js
)<>
instead of writing out<React.Fragment>
changelog
ANALYZER=true
orANALYZER=1
to turn on the bundle analyzer and circular dependency checkingreview requests
Make sure our Flow-based projects still work: