feat(app): Enable new connectivity card #2517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kadee80
added
feature
Kadee80
commented
Oct 19, 2018
Codecov Report
@@ Coverage Diff @@
## edge #2517 +/- ##
==========================================
+ Coverage 50.69% 50.77% +0.08%
==========================================
Files 626 625 -1
Lines 16086 16058 -28
==========================================
- Hits 8155 8154 -1
+ Misses 7931 7904 -27
Continue to review full report at Codecov.
|
Kadee80
commented
Oct 22, 2018
| {SUCCESS_MESSAGE} | ||
| </AlertModal> | ||
| </Portal> | ||
| <AlertModal |
There was a problem hiding this comment.
Moved the WifiConnectModal into SelectNetwork folder
Kadee80
added
the
DO NOT MERGE
|
Removing the feature flag at this time would break backwards compatibility at this time. Closing this PR in favor of a smaller styling specific PR #2522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This PR also serves as a ticket for applying component library styling the wifi dropdown (react-select).
Previous connectivity cards were labeled as refactors due to the fact that any new features were behind a feature flag. This PR also removes the old connectivity card in favor of the old one, which now allows for connecting to unsecure networks and WPA2 personal.
changelog
SelectNetwork+ remove old componentsreview requests
This is a little whacky. A combination of custom components to replace
react-selectdefaults and styling withemotionwas needed to match the designs. I'm open to revisiting this if we move this react-select dropdown into the components library.TODO
Should we hold off on merging this until validation is present in the form? Or at least a disabled submit button when password is empty?