-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): Prevent wrong keypress combo from changing jog jump size #2315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Sunset:
- expected key combos jog the robot or change the jog increment
Click on a radio button to choose a jog increment (focus the form element)
- shift + left/right arrow keys does NOT change the jog increment
- + or - keys still changes jog increment
⌨️
Codecov Report
@@ Coverage Diff @@
## edge #2315 +/- ##
==========================================
+ Coverage 30.16% 30.22% +0.06%
==========================================
Files 502 502
Lines 8053 8169 +116
==========================================
+ Hits 2429 2469 +40
- Misses 5624 5700 +76
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## edge #2315 +/- ##
==========================================
+ Coverage 30.16% 30.22% +0.06%
==========================================
Files 502 502
Lines 8053 8169 +116
==========================================
+ Hits 2429 2469 +40
- Misses 5624 5700 +76
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on VS
⛳ 🥅
overview
This PR closes #2300. Clicking on a jog increment radio button caused an onFocus event which allowed an unused combination of our arrow keys + shift to change the jump size. The solution was to setState and then immediately
.blur()
the clicked element.changelog
review requests
Try it out on VS or a Robot. Open up deck calibration or labware calibration (some screen with jog buttons)
Click on a radio button to choose a jog increment (focus the form element)