fix(app): Fix robot list scroll clipping #2288
Conversation
Kadee80
added
bug
app
There was a problem hiding this comment.
Dunno if it should be part of this PR or not, but the robot list looks pretty messy:
- Unnecessary
<div>between<SidePanel>and<RobotList> <ol>s as direct (and therefore illegal) children of an<ol>- Nested
<ol>s withoutlist-style: noneconfusing the renderer
components/src/nav/SidePanel.css
Outdated
| @@ -33,7 +33,7 @@ | |||
|
|
|||
| .panel_contents { | |||
| width: var(--sidebar-width); | |||
| height: calc(100vh - 2.625rem); | |||
| height: calc(100vh - 4.25rem); | |||
There was a problem hiding this comment.
It looks like the sidebar title is 3.5rem (56px). Is that not where this number was supposed to come from?
There was a problem hiding this comment.
Yes, but there is a little fudging due to margins/spacing. I chose 4.25 rem because it worked with the robot item heights and spacing. 3.5rem cut it a little too close. Happy to revisit.
As for the robot list being messy - this got slugged in a while back, when we were thinking it was only an initial design solution - and we shoehorned in the existing comp lib list item.
@mcous I didn't consider refactoring this as part of this PR, but I say lets get that in there as well. How do we feel about ditching the comp lib list item implementation for the robot lists and considering a custom component for robot items?
Kadee80
force-pushed
the
app_fix-robot-list-scroll
branch
from
a30edc5 to
02959e0
Compare
overview
closes #2046
Turns out the calc function for the height of the scrollable area in the sidebar was about 2rem too high, causing the scrollable area to flow off the page.
changelog
review requests
The sidebar is in the component library, so this change may (but shouldn't) affect the protocol designer. I did a quick check locally but please confirm.