refactor(app): Consolidate /pipettes calls into common API #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kadee80
commented
Sep 13, 2018
| @@ -26,8 +26,7 @@ type SettingsRequest = ?{id: Id, value: Value} | |||
|
|
|||
| type SettingsResponse = {settings: Array<Setting>} | |||
|
|
|||
| export type SettingsAction = | |||
| ApiAction<'settings', SettingsRequest, SettingsResponse> | |||
| export type SettingsAction = ApiAction<'settings', SettingsRequest, SettingsResponse> | |||
There was a problem hiding this comment.
Sorry about this, really a whitespace issue that snuck in. LMK
mcous
approved these changes
Sep 14, 2018
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Small refactor PR in to make future API work around connectivity state easier with regards to #2100.
Since pipettes is a one off case with refresh it does not implement
buildRequestMaker.This pr touches motors as well since they depend on pipettes. Theres a TODO about storing motors in state that might require further discussion.
changelog
review requests
tests pass and everything looks cool on VS but please test all pipette related pages on an actual robot with pipettes to ensure everything still works!
InstrumentSettingspage pipettes cardFileInfopage pipettes section