fix(app): Increase RPC ping threshhold to work around API lock #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
added
bug
app
Codecov Report
@@ Coverage Diff @@
## edge #2106 +/- ##
=======================================
Coverage 32.48% 32.48%
=======================================
Files 452 452
Lines 7264 7264
=======================================
Hits 2360 2360
Misses 4904 4904
Continue to review full report at Codecov.
|
sfoster1
requested changes
Aug 22, 2018
sfoster1
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Bug ticket + fix.
Long running HTTP requests (like POST /robot/home) lock up the webserver, preventing it from responding to the app's RPC pings. If the threshold is low enough, the app will close down the websocket before the API unlocks. #2083 introduced a threshold that was lower than the time it takes the robot to finish homing.
This PR works around that issue by increasing the missed-ping threshold until the system can be rearchitected.
changelog
review requests
Make sure clicking "Home" in the robot settings page doesn't cause the RPC connection to close