feat(discovery-client): Add CLI commands to find and SSH into a robot #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
added
feature
mcous
commented
Aug 16, 2018
discovery-client/README.md
Outdated
| @@ -24,7 +24,7 @@ const options = { | |||
| nameFilter: /^opentrons/i, | |||
| allowedPorts: [31950], | |||
| pollInterval: 5000, | |||
| candidates: [{ip: '[fd00:0:cafe:fefe::1]', port: 31950}, 'localhost'] | |||
| candidates: [{ ip: '[fd00:0:cafe:fefe::1]', port: 31950 }, 'localhost'] | |||
There was a problem hiding this comment.
Sorry for all these whitespace changes; I enabled prettier in my editor and this is the prettier default. Let me know if this bothers you and I can revert
There was a problem hiding this comment.
I don't mind it, its more readable
Codecov Report
@@ Coverage Diff @@
## edge #2072 +/- ##
=========================================
- Coverage 33.03% 33% -0.04%
=========================================
Files 452 452
Lines 7195 7236 +41
=========================================
+ Hits 2377 2388 +11
- Misses 4818 4848 +30
Continue to review full report at Codecov.
|
Kadee80
approved these changes
Aug 20, 2018
|
Got verbal 👍 from Andy |
mcous
commented
Aug 20, 2018
|
|
||
| # example: find the IP address of a wired robot that may be IPv4 or IPv6 | ||
| # (IPv6 means legacy non-mDNS wired configuration) | ||
| discovery find -i "169.254" "fd00" -c "[fd00:0:cafe:fefe::1]" |
There was a problem hiding this comment.
Universal SSH into wired bot command 🎉
20 tasks
b-cooper
pushed a commit
that referenced
this pull request
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
In support of the switch to IPv4, this PR adds a couple commands to the
discovery-clientCLI:discovery find [name] [options]- Find the IP address of a single robot, optionally by namediscovery-ssh [name] [options]- Bash script to calldiscovery findand then SSH into the found robotchangelog
discovery find [name] [options]discovery-ssh [name] [options]review requests
questions
npmmight actually be a good ideatesting
This must be run in an environment with
bashandsshavailable/Run
make installafter checkout to get newyarndependencies and rebuilddiscovery-client.npx discovery-ssh --ipFilter=169.254npx discovery-ssh --candidates="[fd00:0:cafe:fefe::1]" --ipFilter="[fd00"discovery-client/README.mdand make sure they work, toonpx discovery-ssh opentrons-moon-moon