Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): rename change tip options #2003

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

IanLondon
Copy link
Contributor

@IanLondon IanLondon commented Aug 2, 2018

overview

Closes #1933 and addresses part of #1934

image

changelog

  • rename change tip options
  • fix bug with forms defaulting to blank change tip option

review requests

  • make sure change tip options match Tip Use Per Step: Change Tip Copy #1933
  • for all step types, Change Tip should default to "Always" (the first option), and never default to being blank (as was previous behavior for everything but maybe Distribute)

- fix bug with forms defaulting to blank change tip option

Closes #1933
@IanLondon IanLondon added ready for review protocol designer Affects the `protocol-designer` project labels Aug 2, 2018
@codecov
Copy link

codecov bot commented Aug 2, 2018

Codecov Report

Merging #2003 into edge will decrease coverage by 0.04%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #2003      +/-   ##
==========================================
- Coverage   32.16%   32.12%   -0.05%     
==========================================
  Files         429      429              
  Lines        6867     6874       +7     
==========================================
- Hits         2209     2208       -1     
- Misses       4658     4666       +8
Impacted Files Coverage Δ
...er/src/components/StepEditForm/TransferLikeForm.js 0% <ø> (ø) ⬆️
...ol-designer/src/components/StepEditForm/MixForm.js 0% <ø> (ø) ⬆️
protocol-designer/src/steplist/formProcessing.js 2.38% <ø> (-1.15%) ⬇️
protocol-designer/src/steplist/fieldLevel/index.js 38.46% <ø> (-4.4%) ⬇️
...designer/src/components/StepEditForm/formFields.js 0% <0%> (ø) ⬆️
protocol-designer/src/constants.js 52.94% <100%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938a3fa...28f44eb. Read the comment docs.

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📄

const {name, stepType} = props
let options = getChangeTipOptions()
// Override change tip option names for certain step types
switch (stepType) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These overrides would be a perfect place to throw in some parameterized i18n translations, but that could come down the road.

@IanLondon IanLondon merged commit e80fd25 into edge Aug 3, 2018
@IanLondon IanLondon deleted the pd_rename-change-tip-options-1933 branch August 3, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol designer Affects the `protocol-designer` project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tip Use Per Step: Change Tip Copy
3 participants