fix(api): check virtual smoothie before copying udev file to robot #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #1960 +/- ##
=======================================
Coverage 32.23% 32.23%
=======================================
Files 428 428
Lines 6819 6819
=======================================
Hits 2198 2198
Misses 4621 4621Continue to review full report at Codecov.
|
sanni-t
force-pushed
the
api_server-udev-vsmoothie-fix
branch
from
c6c6b54 to
dcef2cf
Compare
|
Made correction as pointed out by Ben |
b-cooper
added a commit
that referenced
this pull request
Aug 6, 2018
* feat(protocol-designer): make pipettes eagerly drop tips (#1946) - drop tips at the end of each step unless the next step for a pipette uses change tip: "never" Closes #1706 * fix(docker): Switch out dumb-init, add modules tools & udev config (#1952) - Switch to Resin's default init system - add avrdude apk & avrdude config file - add udev rules for modules Closes #1822 * feat(comp): Add IntervalWrapper to interaction enhancers (#1942) * fix(protocol-designer): fix styling of pause and mix step items (#1948) Closes #1947 * feat(protocol-designer): add help link to PD nav (#1945) - add 'help-circle' icon - create OutsideLinkButton component for nav - remove negative margin from navbar .bottom - update PD knowledge base URLs Closes #1941 * feat(protocol-designer): add i18next and start with tooltips (#1949) Add the i18next library to help organize our copy, and start off by moving tooltip copy into translations json file. * feat(protocol-designer): refactor and restyle LabwareSelectionModal (#1929) * LabwareSelectionModal component matches design (was AddLabwareModal) * factor out shadows and borders to complib css vars * fix IngredientsList; cleanup borders * make IngredIndividual "hoverable" (presentation only) * fix(api): maintain speed state after collision recovery (#1953) * fix(api): Explicitely set gantry speed after testing an axis for skipping * removes calls to self.set_speed() from driver * fix(api): check virtual smoothie before copying udev file on server start (#1960) * feat(app): Add continuous polling to modules during run (#1961) * feat(api): Add clear method to RPC SessionManager (#1969) * feat(protocol-designer): refactor and restyle timeline terminal items (#1967) - fix bug with `robotStateTimeline` selector creating extra "steps" in the timeline for eager drop tip, introduced in #1706 - fix related bug where substeps didn't generate for `changeTip: "never"` steps - fix bug where hovering over Mix highlights wells of all labware, not just the relevant labware - renamed a handful of selectors touched by this PR to `getSpam` instead of `spam` - create TerminalItem component - change copy of text in initial deck setup, final deck state, and corresponding headers - remove flask icon from initial deck setup - remove `StepTypeWithEnd` and remove `any` typing that was a workaround for it - remove `deckSetupMode` selector - update all places timeline index is used to no longer add 1 to the index to skip over deck setup step (timeline warnings, timeline errors, liquids on deck at step in timeline, well selection) Closes #1930 and closes #1974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Adds a check for virtual smoothie before copying udev files to user_storage on server start
changelog
server/main.pyreview requests