feat(app): Add and implement module selectors in calibration #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
approved these changes
Jul 18, 2018
|
|
||
| type Props = { | ||
| watch?: string, | ||
| refreshing?: boolean, |
| import * as React from 'react' | ||
|
|
||
| type Props = { | ||
| watch?: string, |
There was a problem hiding this comment.
Adding watch to RefreshCard was a mistake on my part. React's built-in key prop was what I should've used (and what we should use here)
| this.props.refresh() | ||
| } | ||
|
|
||
| componentDidUpdate (prevProps: Props) { |
There was a problem hiding this comment.
Can remove this, provided we use key instead of watch
| @@ -78,15 +76,3 @@ function mapStateToProps (state: State, ownProps: OP): SP { | |||
|
|
|||
| return {...NAV_ITEM_BY_NAME[name], _robot} | |||
| } | |||
|
|
|||
| function mergeProps (stateProps: SP, dispatchProps: DP, ownProps: OP): Props { | |||
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This PR addresses #1737 by adding and implementing module selectors and actions in
Calibrate/Labware. It also introduces a RefreshWrapper for pages which is implemented on page mount in order tofetchPipettesandfetchModulesfrom the api.changelog
RefreshWrappercomponent and implement on calibration pagesreview requests
If you'd like to see a populated
modulesBySlotcomment out line343and uncomment lines345-351inapp/src/robot/api-client/client.js. *Please note tests wont pass with this uncommented.calibrate/pipettescalibrate/labwareapi[RobotName].api.modulesexists andresponse = { modules: [ ] }