Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): various odd modal width fixes under i18n #17307

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix(app): various odd modal width fixes under i18n #17307

merged 1 commit into from
Jan 22, 2025

Conversation

sfoster1
Copy link
Member

  • the takeover modal for maintenance runs (RQA-3868)
  • run start confirmation (not tagged yet)
  • run cancel confirmation (RQA-3869)

Closes RQA-3868
Closes RQA-3869

Screenshot 2025-01-17 at 4 58 05 PM Screenshot 2025-01-17 at 4 58 40 PM Screenshot 2025-01-17 at 5 05 22 PM

@sfoster1
fix(app): various odd modal width fixes under i18n
f4d5d51 
- the takeover modal for maintenance runs (RQA-3868)
- run start confirmation (not tagged yet)
- run cancel confirmation (RQA-3869)

Closes RQA-3868
Closes RQA-3869
@sfoster1 sfoster1 requested a review from a team as a code owner January 17, 2025 22:07
@sfoster1 sfoster1 requested review from TamarZanzouri, smb2268 and mjhuff and removed request for a team January 17, 2025 22:07
mjhuff
mjhuff approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes sense. Thanks for fixing!

@sfoster1 sfoster1 merged commit 1e47fe3 into chore_release-8.3.0 Jan 22, 2025
36 checks passed
@sfoster1 sfoster1 deleted the dqa-various-modals branch January 22, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhuff mjhuff mjhuff approved these changes

@TamarZanzouri TamarZanzouri Awaiting requested review from TamarZanzouri TamarZanzouri is a code owner automatically assigned from Opentrons/js

@smb2268 smb2268 Awaiting requested review from smb2268

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfoster1 @mjhuff