Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer, step-generation): add move labware functionality for plate reader #17252

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Jan 10, 2025

Overview

This PR creates necessary labware compatibility checks and lid state error handling for moving labware to or from the absorbance plate reader. Also in scope is adding a thin wrapper for module-labware compatibility to avoid the need to check for module type being plate reader in every use.

Closes AUTH-1216

Test Plan and Hands on Testing

Screen.Recording.2025-01-10.at.4.39.10.PM.mov
  • ensure absorbance reader ff is on
  • create a protocol absorbance reader added
  • try to move an incompatible labware to absorbance reader (like a reservoir or tiprack)
  • verify that you cannot save and get an incompatibility form error
  • try to move a compatible labware to absorbance reader (like Opentrons tough 96 wellplate)
  • verify that you can save the form, but you get the appropriate timeline error that the lid is not open

There is no current way to manipulate the absorbance reader lid state from its initial null state, so we will test correct open-lid functionality in a followup

Changelog

  • refactor module-labware compatibility logic
  • implement lid error handling for plate reader
  • add types

Review requests

  • see test plan

Risk assessment

low

…ity for plate reader

This PR creates necessary labware compatibility checks and lid state error handling for moving labware to or from the absorbance plate reader. Also in scope is adding a thin wrapper for module-labware compatibility to avoid the need to check for module type being plate reader in every use.

Closes AUTH-1216
@ncdiehl11 ncdiehl11 self-assigned this Jan 10, 2025
@ncdiehl11 ncdiehl11 requested review from koji and jerader January 10, 2025 21:40
@ncdiehl11 ncdiehl11 marked this pull request as ready for review January 10, 2025 21:40
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner January 10, 2025 21:40
@ncdiehl11 ncdiehl11 changed the title feat(protocol-designer,-step-generation): add move labware functionality for plate reader feat(protocol-designer,step-generation): add move labware functionality for plate reader Jan 10, 2025
@ncdiehl11 ncdiehl11 changed the title feat(protocol-designer,step-generation): add move labware functionality for plate reader feat(protocol-designer, step-generation): add move labware functionality for plate reader Jan 10, 2025
@ncdiehl11 ncdiehl11 removed the request for review from a team January 10, 2025 21:58
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ncdiehl11 ncdiehl11 merged commit 407506f into edge Jan 13, 2025
22 checks passed
@ncdiehl11 ncdiehl11 deleted the feat_pd-support-platereader-movelabware branch January 13, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants