-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer, step-generation): single channel partial tip support for 'default' primaryNozzle only #17222
Open
jerader
wants to merge
7
commits into
edge
Choose a base branch
from
pd_partial-tip-single-tip-support
base: edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
force-pushed
the
pd_partial-tip-single-tip-support
branch
from
January 8, 2025 21:22
324471b
to
422a6bc
Compare
koji
reviewed
Jan 9, 2025
koji
reviewed
Jan 9, 2025
koji
reviewed
Jan 9, 2025
koji
reviewed
Jan 9, 2025
koji
reviewed
Jan 9, 2025
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/PartialTipField.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Jan 9, 2025
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/StepTools/MixTools/index.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Jan 9, 2025
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/index.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Jan 9, 2025
jerader
force-pushed
the
pd_partial-tip-single-tip-support
branch
from
January 17, 2025 17:14
aa0c7ec
to
471db84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-594 AUTH-596 AUTH-597 AUTH-598 AUTH-599
Overview
This is behind a ff so shouldn't affect anything in 8.3.0, 8.4.0, etc until we want to finish & release this feature
This PR adds single tip partial tip support for 96-channel and 8-channel, only starting at the 'default' primary nozzles which are
H1
for 8-channel andH12
for 96-channel.Note that collision warnings for deck extents, ot-2 and 8-channel are not fully supported yet.
Test Plan and Hands on Testing
Turn on the partial tip FF
Changelog
Risk assessment
low, behind ff