-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add stacker module context and protocol command skeletons #17206
Conversation
64c75d9
to
df3955a
Compare
@@ -54,5 +59,5 @@ | |||
"AbsorbanceReader", | |||
"AbsorbanceReaderStatus", | |||
"AbsorbanceReaderDisconnectedError", | |||
"ModuleDisconnectedCallback", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modules.ModuleDisconnectedCallback
type got removed as the type has not been mported to this file, and hence, will not affect the rest of the code
df3955a
to
69c76de
Compare
69c76de
to
aef78d7
Compare
api/src/opentrons/protocol_engine/commands/flex_stacker/retrieve.py
Outdated
Show resolved
Hide resolved
api/src/opentrons/protocol_engine/commands/flex_stacker/store.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I think our lives will be easier if we add unit tests for retrieve.py
and store.py
now if possible, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢IT!
Overview
This PR adds flex stacker support skeleton in the protocol engine. With the changes in this PR, you can load a flex stacker into your protocol.
Changelog
store
andretrieve
FlexStackerStateUpdate
is created to update the substateApologies in advance, the commit log is a mess... I had to rebase way too many times.