Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add stacker module context and protocol command skeletons #17206

Merged
merged 28 commits into from
Jan 13, 2025

Conversation

ahiuchingau
Copy link
Contributor

@ahiuchingau ahiuchingau commented Jan 7, 2025

Overview

This PR adds flex stacker support skeleton in the protocol engine. With the changes in this PR, you can load a flex stacker into your protocol.

Changelog

  1. FLEX Stacker is added to module core and now has two commands: store and retrieve
  2. Module substate is added for the stacker, and now available in the module state view
  3. FlexStackerStateUpdate is created to update the substate
  4. Fix shared-data deck addressable area names
  5. Added unit tests for the new protocol engine module commands

Apologies in advance, the commit log is a mess... I had to rebase way too many times.

@ahiuchingau ahiuchingau force-pushed the EXEC-1079-module-context branch from 64c75d9 to df3955a Compare January 8, 2025 19:36
@@ -54,5 +59,5 @@
"AbsorbanceReader",
"AbsorbanceReaderStatus",
"AbsorbanceReaderDisconnectedError",
"ModuleDisconnectedCallback",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This modules.ModuleDisconnectedCallback type got removed as the type has not been mported to this file, and hence, will not affect the rest of the code

@ahiuchingau ahiuchingau force-pushed the EXEC-1079-module-context branch from df3955a to 69c76de Compare January 9, 2025 22:17
@ahiuchingau ahiuchingau force-pushed the EXEC-1079-module-context branch from 69c76de to aef78d7 Compare January 9, 2025 22:28
@ahiuchingau ahiuchingau marked this pull request as ready for review January 9, 2025 23:51
@ahiuchingau ahiuchingau requested review from a team as code owners January 9, 2025 23:51
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think our lives will be easier if we add unit tests for retrieve.py and store.py now if possible, though.

shared-data/command/schemas/11.json Outdated Show resolved Hide resolved
@ahiuchingau ahiuchingau requested a review from a team as a code owner January 13, 2025 19:51
@ahiuchingau ahiuchingau requested review from smb2268 and removed request for a team January 13, 2025 19:51
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢IT!

@ahiuchingau ahiuchingau merged commit cec46ef into edge Jan 13, 2025
51 checks passed
@ahiuchingau ahiuchingau deleted the EXEC-1079-module-context branch January 13, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants