Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(app): Revert "Standardize modals and pages" #1718

Closed
wants to merge 1 commit into from

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Jun 18, 2018

Reverts #1705

@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #1718 into edge will increase coverage by 0.25%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #1718      +/-   ##
==========================================
+ Coverage   35.09%   35.35%   +0.25%     
==========================================
  Files         340      340              
  Lines        5570     5632      +62     
==========================================
+ Hits         1955     1991      +36     
- Misses       3615     3641      +26
Impacted Files Coverage Δ
components/src/modals/ModalPage.js 100% <ø> (ø) ⬆️
app/src/pages/Run.js 0% <ø> (ø) ⬆️
app/src/components/App.js 0% <ø> (ø) ⬆️
app/src/pages/More/Resources.js 0% <ø> (ø) ⬆️
app/src/pages/Calibrate/Instruments.js 0% <ø> (ø) ⬆️
app/src/pages/AppSettings.js 0% <0%> (ø)
app/src/pages/Calibrate/Labware.js 0% <0%> (ø) ⬆️
app/src/pages/More/AppSettings.js 0% <0%> (ø) ⬆️
app/src/pages/Robots.js 0% <0%> (ø) ⬆️
app/src/components/SessionHeader/index.js 0% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295940e...9f82f57. Read the comment docs.

@mcous mcous force-pushed the revert-1705-app_refactor-pages-modals branch from cde1811 to 9f82f57 Compare June 18, 2018 18:30
Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems OK to me, PD & Run App look normal

@mcous
Copy link
Contributor Author

mcous commented Jun 18, 2018

Hoping to close this PR in favor of #1719

@mcous mcous closed this Jun 18, 2018
@mcous mcous deleted the revert-1705-app_refactor-pages-modals branch June 18, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants