fix(protocol-designer): unify navigation bar of pd #17128
+242
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the following ticket, I said NavigationBar and ProtocolNavBar should be into one component but it is a big shift for us since ProtocolNavBar requires props that ProtocolRoutes can not access right now.
Technically we can allow ProtocolRoutes to access those props info via useContext but I don't see any strong necessity at this moment. Another way would be checking the path via useLocation and displaying the right Navigation by page, but personally I don't like this because the change will make ProtocolRoutes messy. I think this way would work if we had a function that handle all modals.
For Navigation, update link text style and SettingIcon. Additionally, I move a couple of components to organisms and molecules.
close RQA-3761
Test Plan and Hands on Testing
Navigation is displayed correctly in each page.
Changelog
Review requests
If you think we really need to unify there two navigations into one component, please let me know.
I'm okay with working on that.
Risk assessment
low