-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer, components): add dropdown field deck highlights #17122
Conversation
@@ -118,6 +120,64 @@ const _patchDefaultDropTipLocation = (args: { | |||
return null | |||
} | |||
|
|||
const _patchDefaultLabwareLocations = (args: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this patch auto-populates labware locations for aspirate_labware, dispense_labware, and labware (in mix) when there is 1 item available. Before, we were using useEffect
s in the form toolbox and this way is more clean and follows the pattern of other auto-populated fields
showed this to Felix and there are a few action items remaining
|
@ncdiehl11 thanks! good catch on all of these, will take a look |
protocol-designer/src/molecules/DropdownStepFormField/index.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/DeckSetup/DeckItemHighlight.tsx
Outdated
Show resolved
Hide resolved
@@ -59,7 +61,7 @@ export function DeckLabel({ | |||
|
|||
return ( | |||
<Flex | |||
fontSize="6px" | |||
fontSize={isZoomed ? '6px' : '18px'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this come from 3x zooming somewhere? If so, maybe we should have a zoom scalar constant that can be reused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it comes from the designs. DeckLabel was altered before because when you zoom into the viewbox, everything rendered in it is also zoomed in, including the text. 18px is the original text size for when you're not zoomed in
protocol-designer/src/molecules/DropdownStepFormField/index.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/DeckSetup/HighlightItems.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/DeckSetup/HighlightItems.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/DeckSetup/HighlightItems.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/DeckSetup/HighlightItems.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/Offdeck/HighlightOffdeckSlot.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/Offdeck/OffDeckDetails.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/ui/steps/actions/__tests__/addAndSelectStep.test.ts
Show resolved
Hide resolved
6676596
to
b1ed0b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17122 +/- ##
===========================================
- Coverage 92.43% 74.00% -18.44%
===========================================
Files 77 43 -34
Lines 1283 3250 +1967
===========================================
+ Hits 1186 2405 +1219
- Misses 97 845 +748
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on sandbox and works really well. It's a big PR so it's possible we missed something, but I tested every step successfully with a variety of on and off-deck labware, nested on modules/adapters, etc., and the UI functions great. I will keep an eye out for any possible bugs during dev work pre-8.3 release, but I'm comfortable merging. Awesome work
closes AUTH-1124
Overview
Screen.Recording.2024-12-17.at.09.19.12.mov
This PR adds deck highlights when hovering and selecting the dropdown options for several fields:
Additionally, this PR cleans how we auto-populate the dropdown field if only one is available.
Test Plan and Hands on Testing
There is a lot to test here, basically test that the highlight occurs for each module step, mix, transfer and move labware. After you create the steps, reopen them and see that the highlight is auto-populated back in
Changelog
Risk assessment
low