Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): driver and simulator for FLEX Stacker #17120

Open
wants to merge 4 commits into
base: edge
Choose a base branch
from

Conversation

ahiuchingau
Copy link
Contributor

Overview

This PR adds a driver and a simulator for the FLEX Stacker that follow the same pattern as the other Opentrons modules.

The driver is in charge of sending commands to the device via serial communication, and parsing the responses into data that can be understood by the robot.

What's Next?

I'll implement Stacker module control interface in the hardware controller layer that makes use of the driver.

@ahiuchingau ahiuchingau requested a review from a team as a code owner December 16, 2024 20:18
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! One little typo, and we should add some tests, but the structure looks good

_RE = re.compile(f"^{GCODE.GET_LIMIT_SWITCH} {pattern}")
m = _RE.match(response)
if not m:
raise ValueError(f"Incorrect Response for limit siwtch status: {response}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise ValueError(f"Incorrect Response for limit siwtch status: {response}")
raise ValueError(f"Incorrect Response for limit switch status: {response}")

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants