feat(protocol-designer): make timeline responsive #17109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji
commented
Dec 13, 2024
| } from '@opentrons/components' | ||
| import { TimelineToolbox } from './Timeline/TimelineToolbox' | ||
|
|
||
| const INITIAL_SIDEBAR_WIDTH = 350 |
There was a problem hiding this comment.
i'll get the right value from Mel next week
koji
commented
Dec 13, 2024
| @@ -56,6 +59,7 @@ export function ProtocolSteps(): JSX.Element { | |||
| const [deckView, setDeckView] = useState< | |||
| typeof leftString | typeof rightString | |||
| >(leftString) | |||
| const [targetWidth, setTargetWidth] = useState<number>(350) | |||
There was a problem hiding this comment.
the initial value will be updated.
|
|
Whoa, looks really slick. I do see some highlighting when dragging the timeline toolbox (see "Ending deck"). Not sure if this is blocking, though. Screen.Recording.2024-12-17.at.10.18.12.AM.mov |
jerader
reviewed
Dec 17, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/StepContainer.tsx
Show resolved
Hide resolved
jerader
reviewed
Dec 17, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/StepContainer.tsx
Show resolved
Hide resolved
|
I think the add step menu is being contained by the timeline toolbox container |
jerader
reviewed
Dec 17, 2024
ncdiehl11
requested changes
Dec 17, 2024
| const addStep = (stepType: StepType): ReturnType<any> => | ||
| dispatch(stepsActions.addAndSelectStep({ stepType })) | ||
|
|
||
| const items = getSupportedSteps() | ||
| .filter(stepType => isStepTypeEnabled[stepType]) | ||
| const items = getSupportedSteps(enableComment) |
There was a problem hiding this comment.
maybe
Suggested change
| const items = getSupportedSteps(enableComment) | |
| getSupportedSteps(enableComment). | |
| reduce<JSX.Element[]>((acc, stepType) => { | |
| return getIsStepTypeEnabled(enableComment, modules)[stepType] | |
| ? [...acc, <AddOverflowButton ... />] | |
| : acc | |
| }, []) |
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/AddStepButton.tsx
Outdated
Show resolved
Hide resolved
| white-space: ${NO_WRAP}; | ||
| bottom: 4.2rem; | ||
| border-radius: ${BORDERS.borderRadius8}; | ||
| box-shadow: 0px 1px 3px rgba(0, 0, 0, 0.2); |
There was a problem hiding this comment.
Do we have a constant for this?
There was a problem hiding this comment.
you mean box-shadow or the entire style?
i think we don't have the constant for this part.
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/StepContainer.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/TerminalItemStep.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/TerminalItemStep.tsx
Outdated
Show resolved
Hide resolved
@ncdiehl11 thank you for catching this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
make timeline responsive
close AUTH-877
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low