Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fix failing builds due to oom issues #17103

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix(ci): fix failing builds due to oom issues #17103

merged 1 commit into from
Dec 13, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Dec 13, 2024 •
edited
Loading

Overview

Looks like the macos build in particular is failing due to the node heap running out of available memory. Upping the memory seems to solve this: https://github.com/Opentrons/opentrons/actions/runs/12318600303

Test Plan and Hands on Testing

  • Ensure the linked CI actually passes.

Changelog

  • Increased available node heap limit for CI builds.

Review requests

Does this seem like a reasonable fix?

vegano1
vegano1 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yess!

@mjhuff mjhuff marked this pull request as ready for review December 13, 2024 16:04
@mjhuff mjhuff requested a review from a team as a code owner December 13, 2024 16:04
sfoster1
sfoster1 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof

@mjhuff mjhuff merged commit a7a84df into edge Dec 13, 2024
43 checks passed
@mjhuff mjhuff deleted the increase-node-heap-size-builds branch December 17, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegano1 vegano1 vegano1 approved these changes

@sfoster1 sfoster1 sfoster1 approved these changes

@y3rsh y3rsh Awaiting requested review from y3rsh

@shlokamin shlokamin Awaiting requested review from shlokamin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjhuff @sfoster1 @vegano1